diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2014-09-18 16:33:27 +0200 |
|---|---|---|
| committer | Tero Kristo <t-kristo@ti.com> | 2014-09-29 10:51:13 +0200 |
| commit | 319f1276f9a392526d2f40ecd76c1c829d0cf5fa (patch) | |
| tree | 00c08e28d1cf6f9653e20b79c0107b0b126caca3 /drivers/clk/ti | |
| parent | clk: ti: dra7-atl-clock: fix a memory leak (diff) | |
| download | linux-319f1276f9a392526d2f40ecd76c1c829d0cf5fa.tar.xz linux-319f1276f9a392526d2f40ecd76c1c829d0cf5fa.zip | |
clk: ti: consider the fact that of_clk_get() might return an error
I "forgot" to update the dtb and the kernel crashed:
|Unable to handle kernel NULL pointer dereference at virtual address 0000002e
|PC is at __clk_get_flags+0x4/0xc
|LR is at ti_dt_clockdomains_setup+0x70/0xe8
because I did not have the clock nodes. of_clk_get() returns an error
pointer which is not checked here.
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Diffstat (limited to 'drivers/clk/ti')
| -rw-r--r-- | drivers/clk/ti/clockdomain.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index f1e0038d76ac..b4c5faccaece 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -36,6 +36,11 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) for (i = 0; i < num_clks; i++) { clk = of_clk_get(node, i); + if (IS_ERR(clk)) { + pr_err("%s: Failed get %s' clock nr %d (%ld)\n", + __func__, node->full_name, i, PTR_ERR(clk)); + continue; + } if (__clk_get_flags(clk) & CLK_IS_BASIC) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); |