diff options
| author | Liang He <windhl@126.com> | 2022-09-15 05:11:21 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-10-01 02:14:32 +0200 |
| commit | 058a3996b888ab60eb1857fb4fd28f1b89a9a95a (patch) | |
| tree | 865dca4d5001f1ec46f92565b0d4875ee48028b7 /drivers/clk/ti | |
| parent | clk: tegra20: Fix refcount leak in tegra20_clock_init (diff) | |
| download | linux-058a3996b888ab60eb1857fb4fd28f1b89a9a95a.tar.xz linux-058a3996b888ab60eb1857fb4fd28f1b89a9a95a.zip | |
clk: ti: Balance of_node_get() calls for of_find_node_by_name()
In ti_find_clock_provider(), of_find_node_by_name() will call
of_node_put() for the 'from' argument, possibly putting the node one too
many times. Let's maintain the of_node_get() from the previous search
and only put when we're exiting the function early. This should avoid a
misbalanced reference count on the node.
Fixes: 51f661ef9a10 ("clk: ti: Add ti_find_clock_provider() to use clock-output-names")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220915031121.4003589-1-windhl@126.com
[sboyd@kernel.org: Rewrite commit text, maintain reference instead of
get again]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/ti')
| -rw-r--r-- | drivers/clk/ti/clk.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/clk/ti/clk.c b/drivers/clk/ti/clk.c index ef2a445c63a3..a99279265e40 100644 --- a/drivers/clk/ti/clk.c +++ b/drivers/clk/ti/clk.c @@ -139,11 +139,12 @@ static struct device_node *ti_find_clock_provider(struct device_node *from, break; } } - of_node_put(from); kfree(tmp); - if (found) + if (found) { + of_node_put(from); return np; + } /* Fall back to using old node name base provider name */ return of_find_node_by_name(from, name); |