diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-04-04 16:59:29 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@codeaurora.org> | 2015-04-09 17:19:31 +0200 |
| commit | e52786ac3ca721636a6fb0ae88521f5b9ece88a3 (patch) | |
| tree | 4d38160ab42c14fa65ca356ada2b792447b0cc3b /drivers/clk/versatile/clk-versatile.c | |
| parent | clk: qcom: Fix parent_map translations (diff) | |
| download | linux-e52786ac3ca721636a6fb0ae88521f5b9ece88a3.tar.xz linux-e52786ac3ca721636a6fb0ae88521f5b9ece88a3.zip | |
clk: versatile: test returned value
Put NULL test on the result of the previous call instead on one of its
arguments. A simplified version of the semantic match that finds this
problem is as follows (http://coccinelle.lip6.fr/):
// <smpl>
r@
expression *e1;
expression *e2;
identifier f;
statement S1,S2;
@@
e1 = f(...,e2,...);
(
if (e1 == NULL || ...) S1 else S2
|
*if (e2 == NULL || ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/versatile/clk-versatile.c')
| -rw-r--r-- | drivers/clk/versatile/clk-versatile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c index a76981e88cb6..7a4f8635bd1e 100644 --- a/drivers/clk/versatile/clk-versatile.c +++ b/drivers/clk/versatile/clk-versatile.c @@ -69,7 +69,7 @@ static void __init cm_osc_setup(struct device_node *np, struct device_node *parent; parent = of_get_parent(np); - if (!np) { + if (!parent) { pr_err("no parent on core module clock\n"); return; } |