diff options
| author | Maxime Ripard <maxime.ripard@free-electrons.com> | 2016-05-11 20:57:44 +0200 |
|---|---|---|
| committer | Maxime Ripard <maxime.ripard@free-electrons.com> | 2016-06-10 11:49:15 +0200 |
| commit | 4de2d58bc973caa8988b44ddd11787e57051c843 (patch) | |
| tree | e2568a9df7272d15d3583eb0a820f336065f2bf9 /drivers/clk | |
| parent | Linux 4.7-rc1 (diff) | |
| download | linux-4de2d58bc973caa8988b44ddd11787e57051c843.tar.xz linux-4de2d58bc973caa8988b44ddd11787e57051c843.zip | |
clk: sunxi: tcon-ch1: Do not return a negative error in get_parent
get_parent is supposed to return an unsigned 8 bit integer, so returning
-EINVAL is a bad idea.
Remove it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Diffstat (limited to 'drivers/clk')
| -rw-r--r-- | drivers/clk/sunxi/clk-sun4i-tcon-ch1.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c b/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c index 98a4582de56a..248585238b1c 100644 --- a/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c +++ b/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c @@ -85,9 +85,6 @@ static u8 tcon_ch1_get_parent(struct clk_hw *hw) reg = readl(tclk->reg) >> TCON_CH1_SCLK2_MUX_SHIFT; reg &= reg >> TCON_CH1_SCLK2_MUX_MASK; - if (reg >= num_parents) - return -EINVAL; - return reg; } |