summaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-09-05 21:00:20 +0200
committerDave Jones <davej@redhat.com>2010-10-22 17:44:47 +0200
commitb2a33c172890b231444803b0bb38c25ac5a0f274 (patch)
tree82c2da16eb7facfccdbdaea0a3b731f57f377081 /drivers/cpufreq
parent[CPUFREQ] drivers/cpufreq: Adjust confusing if indentation (diff)
downloadlinux-b2a33c172890b231444803b0bb38c25ac5a0f274.tar.xz
linux-b2a33c172890b231444803b0bb38c25ac5a0f274.zip
[CPUFREQ] arch/x86/kernel/cpu/cpufreq: Fix unsigned return type
In each case, the function has an unsigned return type, but returns a negative constant to indicate an error condition. Each function is only called once. For nforce2_detect_chipset, the result is only compared to 0, and for longrun_determine_freqs, the result is stored in a variable of type (signed) int. Thus, for both functions, unsigned can be dropped from the return type. A sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ identifier f; constant C; @@ unsigned f(...) { <+... * return -C; ...+> } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Dave Jones <davej@redhat.com>
Diffstat (limited to 'drivers/cpufreq')
0 files changed, 0 insertions, 0 deletions