diff options
author | Viresh Kumar <viresh.kumar@linaro.org> | 2014-06-10 06:57:12 +0200 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-06-10 22:50:50 +0200 |
commit | 40cc5490132075d7be85a4483caa0a7264f45ed4 (patch) | |
tree | 736d05bc242ec8a07e9638c3ca0fb2ba8e28106e /drivers/cpufreq | |
parent | cpufreq: intel_pstate: Remove duplicate CPU ID check (diff) | |
download | linux-40cc5490132075d7be85a4483caa0a7264f45ed4.tar.xz linux-40cc5490132075d7be85a4483caa0a7264f45ed4.zip |
cpufreq: tegra: update comment for clarity
Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate
frequency callbacks) and implements new 'intermediate freq' infrastructure of
core. Above commit updated comments about when to call
clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and
said this:
> The "Though when target-freq is intermediate freq, we don't need to
> take this reference." makes me think that this function is actually
> called when target-freq is intermediate freq. I don't think it is,
> right?
For better clarity just make that comment more explicit about when we call
tegra_target_intermediate().
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Reported-and-reviewed-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq')
-rw-r--r-- | drivers/cpufreq/tegra-cpufreq.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index a5fbc0a8d897..8084c7f7e206 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -71,9 +71,12 @@ static int tegra_target_intermediate(struct cpufreq_policy *policy, /* * Take an extra reference to the main pll so it doesn't turn * off when we move the cpu off of it as enabling it again while we - * switch to it from tegra_target() would take additional time. Though - * when target-freq is intermediate freq, we don't need to take this - * reference. + * switch to it from tegra_target() would take additional time. + * + * When target-freq is equal to intermediate freq we don't need to + * switch to an intermediate freq and so this routine isn't called. + * Also, we wouldn't be using pll_x anymore and must not take extra + * reference to it, as it can be disabled now to save some power. */ clk_prepare_enable(pll_x_clk); |