diff options
| author | Vladimir Zapolskiy <vz@mleia.com> | 2016-03-06 02:21:52 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2016-03-11 14:19:19 +0100 |
| commit | 9b52d55f4f0e2bb9a34abbcf99e05e17f1b3b281 (patch) | |
| tree | 405dc4efa814dc0e2e32d43558d155e9446d0de4 /drivers/crypto/atmel-tdes.c | |
| parent | crypto: qat - Change the definition of icp_qat_uof_regtype (diff) | |
| download | linux-9b52d55f4f0e2bb9a34abbcf99e05e17f1b3b281.tar.xz linux-9b52d55f4f0e2bb9a34abbcf99e05e17f1b3b281.zip | |
crypto: atmel - fix checks of error code returned by devm_ioremap_resource()
The change fixes potential oops while accessing iomem on invalid
address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never
returns NULL, which makes useless a following check for NULL.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Fixes: b0e8b3417a62 ("crypto: atmel - use devm_xxx() managed function")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/atmel-tdes.c')
| -rw-r--r-- | drivers/crypto/atmel-tdes.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 2c7a628d0375..bf467d7be35c 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -1417,9 +1417,9 @@ static int atmel_tdes_probe(struct platform_device *pdev) } tdes_dd->io_base = devm_ioremap_resource(&pdev->dev, tdes_res); - if (!tdes_dd->io_base) { + if (IS_ERR(tdes_dd->io_base)) { dev_err(dev, "can't ioremap\n"); - err = -ENOMEM; + err = PTR_ERR(tdes_dd->io_base); goto res_err; } |