summaryrefslogtreecommitdiffstats
path: root/drivers/crypto/axis
diff options
context:
space:
mode:
authorVincent Whitchurch <rabinv@axis.com>2019-01-23 12:59:46 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2019-02-01 07:42:04 +0100
commit341a64c7e69f54e319ac187721b342f7620af6d6 (patch)
treea3f4a941620e201011ff1e104bd130a5abfda60d /drivers/crypto/axis
parentcrypto: axis - use a constant time tag compare (diff)
downloadlinux-341a64c7e69f54e319ac187721b342f7620af6d6.tar.xz
linux-341a64c7e69f54e319ac187721b342f7620af6d6.zip
crypto: axis - move request unmap outside of the queue lock
The request unmap and bounce buffer copying is currently unnecessarily done while holding the queue spin lock. Signed-off-by: Lars Persson <larper@axis.com> Signed-off-by: Vincent Whitchurch <rabinv@axis.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/axis')
-rw-r--r--drivers/crypto/axis/artpec6_crypto.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index 109efab6a9df..57e5dca3253f 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -2127,11 +2127,7 @@ static void artpec6_crypto_task(unsigned long data)
list_move_tail(&req->list, &complete_done);
- artpec6_crypto_dma_unmap_all(req);
- artpec6_crypto_copy_bounce_buffers(req);
-
ac->pending_count--;
- artpec6_crypto_common_destroy(req);
}
artpec6_crypto_process_queue(ac, &complete_in_progress);
@@ -2142,6 +2138,10 @@ static void artpec6_crypto_task(unsigned long data)
* to allow new request submissions from the callbacks.
*/
list_for_each_entry_safe(req, n, &complete_done, list) {
+ artpec6_crypto_dma_unmap_all(req);
+ artpec6_crypto_copy_bounce_buffers(req);
+ artpec6_crypto_common_destroy(req);
+
req->complete(req->req);
}