diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-24 09:54:33 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-08-02 06:44:32 +0200 |
| commit | 3bd4952853d69659e58d1d4a4964383cb536b5be (patch) | |
| tree | e4aee889a1d4cf61c7e27bf1d8b8421283d56e71 /drivers/crypto/nx | |
| parent | crypto: user - fix potential warnings in cryptouser.h (diff) | |
| download | linux-3bd4952853d69659e58d1d4a4964383cb536b5be.tar.xz linux-3bd4952853d69659e58d1d4a4964383cb536b5be.zip | |
crypto: nx - Add of_node_put() before return in 842
Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.
Acked-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/nx')
| -rw-r--r-- | drivers/crypto/nx/nx-842-powernv.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c index e78ff5c65ed6..c037a2403b82 100644 --- a/drivers/crypto/nx/nx-842-powernv.c +++ b/drivers/crypto/nx/nx-842-powernv.c @@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void) ret = nx842_powernv_probe_vas(dn); if (ret) { nx842_delete_coprocs(); + of_node_put(dn); return ret; } } |