diff options
| author | Robert Richter <rrichter@amd.com> | 2022-10-18 15:23:31 +0200 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2022-11-14 19:37:08 +0100 |
| commit | f3cd264c4ec1ab9b8918f3b083cfc13c5e7c26b7 (patch) | |
| tree | ae7deb9ea29eb9cb343424b880e8ddcf08532f32 /drivers/cxl/acpi.c | |
| parent | cxl/core: Check physical address before mapping it in devm_cxl_iomap_block() (diff) | |
| download | linux-f3cd264c4ec1ab9b8918f3b083cfc13c5e7c26b7.tar.xz linux-f3cd264c4ec1ab9b8918f3b083cfc13c5e7c26b7.zip | |
cxl: Unify debug messages when calling devm_cxl_add_port()
CXL ports are added in a couple of code paths using devm_cxl_add_port().
Debug messages are individually generated, but are incomplete and
inconsistent. Change this by moving its generation to
devm_cxl_add_port(). This unifies the messages and reduces code
duplication. Also, generate messages on failure. Use a
__devm_cxl_add_port() wrapper to keep the readability of the error
exits.
Signed-off-by: Robert Richter <rrichter@amd.com>
Link: https://lore.kernel.org/r/20221018132341.76259-4-rrichter@amd.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/cxl/acpi.c')
| -rw-r--r-- | drivers/cxl/acpi.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index fb649683dd3a..767a91f44221 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -220,7 +220,6 @@ static int add_host_bridge_uport(struct device *match, void *arg) port = devm_cxl_add_port(host, match, dport->component_reg_phys, dport); if (IS_ERR(port)) return PTR_ERR(port); - dev_dbg(host, "%s: add: %s\n", dev_name(match), dev_name(&port->dev)); return 0; } @@ -466,7 +465,6 @@ static int cxl_acpi_probe(struct platform_device *pdev) root_port = devm_cxl_add_port(host, host, CXL_RESOURCE_NONE, NULL); if (IS_ERR(root_port)) return PTR_ERR(root_port); - dev_dbg(host, "add: %s\n", dev_name(&root_port->dev)); rc = bus_for_each_dev(adev->dev.bus, NULL, root_port, add_host_bridge_dport); |