diff options
| author | Robert Richter <rrichter@amd.com> | 2023-01-25 09:57:28 +0100 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2023-01-27 00:57:30 +0100 |
| commit | ee611e5e6616f7981939cc0441a5fb531312c2b6 (patch) | |
| tree | 38a7cb694ffb7f931222979f1343679f8fc2faa1 /drivers/cxl | |
| parent | cxl/port: Link the 'parent_dport' in portX/ and endpointX/ sysfs (diff) | |
| download | linux-ee611e5e6616f7981939cc0441a5fb531312c2b6.tar.xz linux-ee611e5e6616f7981939cc0441a5fb531312c2b6.zip | |
cxl/mbox: Add debug messages for enabled mailbox commands
Only unsupported mailbox commands are reported in debug messages. A
list of enabled commands is useful too. Change debug messages to also
report the opcodes of enabled commands. Esp. if card initialization
fails there is no way to get this information from userland.
On that occasion also add missing trailing newlines.
Signed-off-by: Robert Richter <rrichter@amd.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230125085728.234697-1-rrichter@amd.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/cxl')
| -rw-r--r-- | drivers/cxl/core/mbox.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index b03fba212799..cae43cea00cd 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -610,11 +610,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel) if (!cmd) { dev_dbg(cxlds->dev, - "Opcode 0x%04x unsupported by driver", opcode); + "Opcode 0x%04x unsupported by driver\n", opcode); continue; } set_bit(cmd->info.id, cxlds->enabled_cmds); + dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode); } } |