summaryrefslogtreecommitdiffstats
path: root/drivers/dio
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-10-05 14:10:49 +0200
committerDavid S. Miller <davem@davemloft.net>2012-10-07 20:37:11 +0200
commit14834540cafff24944affd6290f01359799a48ce (patch)
treeef2c35495e4244d8219c7607a400211011021699 /drivers/dio
parentdrivers/net/irda/sh_irda.c: fix error return code (diff)
downloadlinux-14834540cafff24944affd6290f01359799a48ce.tar.xz
linux-14834540cafff24944affd6290f01359799a48ce.zip
drivers/net/irda/sh_sir.c: fix error return code
The function sh_sir_probe() return 0 for success and negative value for most of its internal tests failures. There are two exceptions that are error cases going to err_mem_*:. For this two cases, the function abort its success execution path, but returns non negative value, making it dificult for a caller function to notice the error. This patch fixes the error cases that do not return negative values. This was found by Coccinelle, but the code change was made by hand. This patch is not robot generated. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/dio')
0 files changed, 0 insertions, 0 deletions