diff options
| author | Christian König <christian.koenig@amd.com> | 2022-01-19 14:37:41 +0100 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2022-02-08 09:20:39 +0100 |
| commit | 270b48bb8da7452b4357d8726933beba72652310 (patch) | |
| tree | e36fe572131515969f3fa2f6f14a5a83afb80628 /drivers/dma-buf | |
| parent | dma-buf: warn about dma_fence_array container rules v2 (diff) | |
| download | linux-270b48bb8da7452b4357d8726933beba72652310.tar.xz linux-270b48bb8da7452b4357d8726933beba72652310.zip | |
dma-buf: Warn about dma_fence_chain container rules v2
Chaining of dma_fence_chain objects is only allowed through the prev
fence and not through the contained fence.
Warn about that when we create a dma_fence_chain.
v2: fix comment style
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220204100429.2049-4-christian.koenig@amd.com
Diffstat (limited to 'drivers/dma-buf')
| -rw-r--r-- | drivers/dma-buf/dma-fence-chain.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c index 1b4cb3e5cec9..084c6927b735 100644 --- a/drivers/dma-buf/dma-fence-chain.c +++ b/drivers/dma-buf/dma-fence-chain.c @@ -254,5 +254,14 @@ void dma_fence_chain_init(struct dma_fence_chain *chain, dma_fence_init(&chain->base, &dma_fence_chain_ops, &chain->lock, context, seqno); + + /* + * Chaining dma_fence_chain container together is only allowed through + * the prev fence and not through the contained fence. + * + * The correct way of handling this is to flatten out the fence + * structure into a dma_fence_array by the caller instead. + */ + WARN_ON(dma_fence_is_chain(fence)); } EXPORT_SYMBOL(dma_fence_chain_init); |