diff options
author | Yu Kuai <yukuai3@huawei.com> | 2020-08-17 13:57:26 +0200 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2020-08-19 06:28:37 +0200 |
commit | 0cef8e2c5a07d482ec907249dbd6687e8697677f (patch) | |
tree | d05dda5202af6e185825ee193695bb006af46033 /drivers/dma/at_hdmac.c | |
parent | dmaengine: of-dma: Fix of_dma_router_xlate's of_dma_xlate handling (diff) | |
download | linux-0cef8e2c5a07d482ec907249dbd6687e8697677f.tar.xz linux-0cef8e2c5a07d482ec907249dbd6687e8697677f.zip |
dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate()
The reurn value of of_find_device_by_node() is not checked, thus null
pointer dereference will be triggered if of_find_device_by_node()
failed.
Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20200817115728.1706719-2-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/at_hdmac.c')
-rw-r--r-- | drivers/dma/at_hdmac.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 45bbcd6146fd..1c941f839c42 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1650,6 +1650,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, return NULL; dmac_pdev = of_find_device_by_node(dma_spec->np); + if (!dmac_pdev) + return NULL; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); |