diff options
| author | Anatolij Gustschin <agust@denx.de> | 2010-11-22 18:35:18 +0100 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2010-12-05 00:03:46 +0100 |
| commit | d2f5c276ea4b7b7e1b953926bac9d0b148fcce4e (patch) | |
| tree | 5811fc0b75149a20fb5cdc7102d697ec699d005c /drivers/dma/imx-sdma.c | |
| parent | drivers/dma/ppc4xx: Use printf extension %pR for struct resource (diff) | |
| download | linux-d2f5c276ea4b7b7e1b953926bac9d0b148fcce4e.tar.xz linux-d2f5c276ea4b7b7e1b953926bac9d0b148fcce4e.zip | |
dmaengine: imx-sdma: fix bug in buffer descriptor initialization
Currently while submitting scatterlists with more than one SG
entry the DMA buffer address from the first SG entry is inserted
into all initialized DMA buffer descriptors. This is due to the
typo in the for_each_sg() loop where the scatterlist pointer is
used for obtaining the DMA buffer address and _not_ the SG list
iterator.
As a result all received data will be written only into the first
DMA buffer while reading. While writing the data from the first
DMA buffer is send to the device multiple times. This caused
the filesystem destruction on the MMC card when using DMA in
mxcmmc driver.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma/imx-sdma.c')
| -rw-r--r-- | drivers/dma/imx-sdma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0834323a0599..13d6447a35f6 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -951,7 +951,7 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg( struct sdma_buffer_descriptor *bd = &sdmac->bd[i]; int param; - bd->buffer_addr = sgl->dma_address; + bd->buffer_addr = sg->dma_address; count = sg->length; |