diff options
| author | Leonid Ravich <Leonid.Ravich@emc.com> | 2020-04-22 23:09:18 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-04-23 09:21:45 +0200 |
| commit | db474931df3eb54edbf761b8c98ba517bdf24463 (patch) | |
| tree | bcf4d34d9ae186bfbd72071dac992a2132274d1a /drivers/dma/ioat/dma.c | |
| parent | dmaengine: ioat: remove unnesesery double complition timer modification. (diff) | |
| download | linux-db474931df3eb54edbf761b8c98ba517bdf24463.tar.xz linux-db474931df3eb54edbf761b8c98ba517bdf24463.zip | |
dmaengine: ioat: adding missed issue_pending to timeout handler
completion timeout might trigger unnesesery DMA engine hw reboot
in case of missed issue_pending() .
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Leonid Ravich <Leonid.Ravich@emc.com>
Link: https://lore.kernel.org/r/1587589761-32690-3-git-send-email-leonid.ravich@dell.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/ioat/dma.c')
| -rw-r--r-- | drivers/dma/ioat/dma.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 55a8cf181816..8ad0ad861c86 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -955,6 +955,15 @@ void ioat_timer_event(struct timer_list *t) goto unlock_out; } + /* handle missed issue pending case */ + if (ioat_ring_pending(ioat_chan)) { + dev_warn(to_dev(ioat_chan), + "Completion timeout with pending descriptors\n"); + spin_lock_bh(&ioat_chan->prep_lock); + __ioat_issue_pending(ioat_chan); + spin_unlock_bh(&ioat_chan->prep_lock); + } + set_bit(IOAT_COMPLETION_ACK, &ioat_chan->state); mod_timer(&ioat_chan->timer, jiffies + COMPLETION_TIMEOUT); unlock_out: |