diff options
author | Geert Uytterhoeven <geert+renesas@glider.be> | 2015-02-26 11:26:34 +0100 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2015-03-02 17:40:44 +0100 |
commit | b6d1778bc5485c55c6f5194b8b2ea84c0ce5adad (patch) | |
tree | 38f42da0239e056a37ea2864f047476545874473 /drivers/dma/mmp_tdma.c | |
parent | dmaenegine: mmp-pdma: fix irq handler overwrite physical chan issue (diff) | |
download | linux-b6d1778bc5485c55c6f5194b8b2ea84c0ce5adad.tar.xz linux-b6d1778bc5485c55c6f5194b8b2ea84c0ce5adad.zip |
dmaengine: shdma: Move DMA stop to (runtime) suspend callbacks
During system reboot, the sh-dma-engine device may be runtime-suspended,
causing a crash:
Unhandled fault: imprecise external abort (0x1406) at 0x0002c02c
Internal error: : 1406 [#1] SMP ARM
...
PC is at sh_dmae_ctl_stop+0x28/0x64
LR is at sh_dmae_ctl_stop+0x24/0x64
If the sh-dma-engine is runtime-suspended, its module clock is turned
off, and its registers cannot be accessed.
To fix this, move the call to sh_dmae_ctl_stop(), which touches the
DMAOR register, to the sh_dmae_suspend() and sh_dmae_runtime_suspend()
callbacks. This makes PM operations more symmetric, as both
sh_dmae_resume() and sh_dmae_runtime_resume() already call sh_dmae_rst()
to re-initialize the DMAOR register.
Remove sh_dmae_shutdown(), as it became empty.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/mmp_tdma.c')
0 files changed, 0 insertions, 0 deletions