diff options
| author | Ezequiel Garcia <ezequiel.garcia@free-electrons.com> | 2014-03-07 20:46:45 +0100 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2014-04-10 21:26:17 +0200 |
| commit | 890766d278548afdc059cd977687c4f1297d72a0 (patch) | |
| tree | dc150cac806db3e0d8d7630af494550d30130384 /drivers/dma/mv_xor.c | |
| parent | ioat: Use pci_enable_msix_exact() instead of pci_enable_msix() (diff) | |
| download | linux-890766d278548afdc059cd977687c4f1297d72a0.tar.xz linux-890766d278548afdc059cd977687c4f1297d72a0.zip | |
dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call
In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots()
when the transaction is complete (the cookie status is DMA_COMPLETE).
However, a completed status means that mv_xor_slot_cleanup() was called,
which cleans the completed slots.
In other words, there's nothing to cleanup for a completed transaction in
mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots().
Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma/mv_xor.c')
| -rw-r--r-- | drivers/dma/mv_xor.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index e70f271c99fa..e2c8ec91155e 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan, enum dma_status ret; ret = dma_cookie_status(chan, cookie, txstate); - if (ret == DMA_COMPLETE) { - mv_xor_clean_completed_slots(mv_chan); + if (ret == DMA_COMPLETE) return ret; - } mv_xor_slot_cleanup(mv_chan); return dma_cookie_status(chan, cookie, txstate); |