summaryrefslogtreecommitdiffstats
path: root/drivers/dma/pch_dma.c
diff options
context:
space:
mode:
authorKulikov Vasiliy <segooon@gmail.com>2010-07-17 17:19:48 +0200
committerDan Williams <dan.j.williams@intel.com>2010-08-04 23:27:47 +0200
commitb9033e682e86f3c6a66763f9b6a3935c5c64e145 (patch)
tree8aeeb08aeae97b12f0c6cb7338d8cbcf15e6f8ac /drivers/dma/pch_dma.c
parentioat2: catch and recover from broken vtd configurations v6 (diff)
downloadlinux-b9033e682e86f3c6a66763f9b6a3935c5c64e145.tar.xz
linux-b9033e682e86f3c6a66763f9b6a3935c5c64e145.zip
dma: dmatest: fix potential sign bug
'cnt' is unsigned, so this code may become wrong in future as dmatest_add_threads() can return error code: cnt = dmatest_add_threads(dtc, DMA_MEMCPY); thread_count += cnt > 0 ? cnt : 0; ^^^^^^^ Now it can return only -EINVAL if and only if second argument of dmatest_add_threads() is not one of DMA_MEMCPY, DMA_XOR, DMA_PQ. So, now it is not wrong but may become wrong in future. The semantic patch that finds this problem (many false-positive results): (http://coccinelle.lip6.fr/) // <smpl> @ r1 @ identifier f; @@ int f(...) { ... } @@ identifier r1.f; type T; unsigned T x; @@ *x = f(...) ... *x > 0 Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma/pch_dma.c')
0 files changed, 0 insertions, 0 deletions