diff options
| author | Maninder Singh <maninder1.s@samsung.com> | 2015-05-25 21:10:05 +0200 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2015-05-25 19:06:08 +0200 |
| commit | f5636854f3fcee3dcb45a9d0122cf099e72615e5 (patch) | |
| tree | 27edf590777a817ad33bf1f0ece708b694cc3df8 /drivers/dma/pl330.c | |
| parent | dmaengine: shdma: r8a73a4: Make dma_ts_shift[] static (diff) | |
| download | linux-f5636854f3fcee3dcb45a9d0122cf099e72615e5.tar.xz linux-f5636854f3fcee3dcb45a9d0122cf099e72615e5.zip | |
dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
Currently pch pointer is already dereferenced before NULL check
and thus we are getting below warning:
warn: variable dereferenced before check 'pch'
So initialize struct pl330_dmac *pl330 after NULL check
of dma_pl330_chan *pch.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/pl330.c')
| -rw-r--r-- | drivers/dma/pl330.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index a7d9d3029b14..7e2714478e45 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst, { struct dma_pl330_desc *desc; struct dma_pl330_chan *pch = to_pchan(chan); - struct pl330_dmac *pl330 = pch->dmac; + struct pl330_dmac *pl330; int burst; if (unlikely(!pch || !len)) return NULL; + pl330 = pch->dmac; + desc = __pl330_prep_dma_memcpy(pch, dst, src, len); if (!desc) return NULL; |