diff options
| author | Fabien Dessenne <fabien.dessenne@st.com> | 2019-04-24 11:21:25 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-04-26 19:03:34 +0200 |
| commit | f4fd2ec08f17b34f1c7c18414d5fc882efd51e83 (patch) | |
| tree | b29814a2e91e86f3c4ec2e82bd854284e1deee09 /drivers/dma/stm32-dma.c | |
| parent | dmaengine: rcar-dmac: Update copyright information (diff) | |
| download | linux-f4fd2ec08f17b34f1c7c18414d5fc882efd51e83.tar.xz linux-f4fd2ec08f17b34f1c7c18414d5fc882efd51e83.zip | |
dmaengine: stm32-dma: use platform_get_irq()
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it was
not retrieved earlier.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/stm32-dma.c')
| -rw-r--r-- | drivers/dma/stm32-dma.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c index ba239b529fa9..33068185c0fe 100644 --- a/drivers/dma/stm32-dma.c +++ b/drivers/dma/stm32-dma.c @@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev) for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) { chan = &dmadev->chan[i]; - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - ret = -EINVAL; - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); + chan->irq = platform_get_irq(pdev, i); + if (chan->irq < 0) { + ret = chan->irq; + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "No irq resource for chan %d\n", i); goto err_unregister; } - chan->irq = res->start; ret = devm_request_irq(&pdev->dev, chan->irq, stm32_dma_chan_irq, 0, dev_name(chan2dev(chan)), chan); |