summaryrefslogtreecommitdiffstats
path: root/drivers/dma/sun6i-dma.c
diff options
context:
space:
mode:
authorMaxime Ripard <maxime.ripard@free-electrons.com>2014-07-30 10:30:22 +0200
committerVinod Koul <vinod.koul@intel.com>2014-07-30 15:44:17 +0200
commit174427c1bb9e7810743f55a90a64da2c29d67b0b (patch)
tree75b4834190524909ccec81820ac7d0174392f428 /drivers/dma/sun6i-dma.c
parentdmaengine: sun6i: Remove switch statement from buswidth convertion routine (diff)
downloadlinux-174427c1bb9e7810743f55a90a64da2c29d67b0b.tar.xz
linux-174427c1bb9e7810743f55a90a64da2c29d67b0b.zip
dmaengine: sun6i: Free the interrupt before killing the tasklet
There's still a small window between the call to sun6i_kill_tasklet and the end of the driver remove function where a spurious interrupt might trigger, and start using deallocated resources. Replace the call to synchronize_irq by a free_irq, so that we're sure that we won't get any further interrupts when we're deallocating resources. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/sun6i-dma.c')
-rw-r--r--drivers/dma/sun6i-dma.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index 609c5d8cb947..63a1db38894e 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -836,8 +836,8 @@ static inline void sun6i_kill_tasklet(struct sun6i_dma_dev *sdev)
/* Prevent spurious interrupts from scheduling the tasklet */
atomic_inc(&sdev->tasklet_shutdown);
- /* Make sure all interrupts are handled */
- synchronize_irq(sdev->irq);
+ /* Make sure we won't have any further interrupts */
+ devm_free_irq(sdev->slave.dev, sdev->irq, sdev);
/* Actually prevent the tasklet from being scheduled */
tasklet_kill(&sdev->task);