diff options
| author | Yongzhi Liu <lyz_cs@pku.edu.cn> | 2022-01-16 06:34:56 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-02-15 06:34:16 +0100 |
| commit | 455896c53d5b803733ddd84e1bf8a430644439b6 (patch) | |
| tree | 6d30f18cee1c13a1c2157cc6a0002fe792e7b8c5 /drivers/dma | |
| parent | dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size (diff) | |
| download | linux-455896c53d5b803733ddd84e1bf8a430644439b6.tar.xz linux-455896c53d5b803733ddd84e1bf8a430644439b6.zip | |
dmaengine: shdma: Fix runtime PM imbalance on error
pm_runtime_get_() increments the runtime PM usage counter even
when it returns an error code, thus a matching decrement is needed on
the error handling path to keep the counter balanced.
Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
Link: https://lore.kernel.org/r/1642311296-87020-1-git-send-email-lyz_cs@pku.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/sh/shdma-base.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c index 158e5e7defae..b26ed690f03c 100644 --- a/drivers/dma/sh/shdma-base.c +++ b/drivers/dma/sh/shdma-base.c @@ -115,8 +115,10 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx) ret = pm_runtime_get(schan->dev); spin_unlock_irq(&schan->chan_lock); - if (ret < 0) + if (ret < 0) { dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret); + pm_runtime_put(schan->dev); + } pm_runtime_barrier(schan->dev); |