diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-06-24 15:49:40 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-07-05 09:15:56 +0200 |
| commit | 4c89cc73d1da42ae48b5c5dfbfd12304d0b86786 (patch) | |
| tree | 624c7e0af9e3bbd37d11f68c5d7fea7d4a6b946b /drivers/dma | |
| parent | Linux 5.2-rc4 (diff) | |
| download | linux-4c89cc73d1da42ae48b5c5dfbfd12304d0b86786.tar.xz linux-4c89cc73d1da42ae48b5c5dfbfd12304d0b86786.zip | |
dmaengine: jz4780: Fix an endian bug in IRQ handler
The "pending" variable was a u32 but we cast it to an unsigned long
pointer when we do the for_each_set_bit() loop. The problem is that on
big endian 64bit systems that results in an out of bounds read.
Fixes: 4e4106f5e942 ("dmaengine: jz4780: Fix transfers being ACKed too soon")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/dma-jz4780.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c index 263bee76ef0d..6b8c4c458e8a 100644 --- a/drivers/dma/dma-jz4780.c +++ b/drivers/dma/dma-jz4780.c @@ -718,12 +718,13 @@ static irqreturn_t jz4780_dma_irq_handler(int irq, void *data) { struct jz4780_dma_dev *jzdma = data; unsigned int nb_channels = jzdma->soc_data->nb_channels; - uint32_t pending, dmac; + unsigned long pending; + uint32_t dmac; int i; pending = jz4780_dma_ctrl_readl(jzdma, JZ_DMA_REG_DIRQP); - for_each_set_bit(i, (unsigned long *)&pending, nb_channels) { + for_each_set_bit(i, &pending, nb_channels) { if (jz4780_dma_chan_irq(jzdma, &jzdma->chan[i])) pending &= ~BIT(i); } |