summaryrefslogtreecommitdiffstats
path: root/drivers/dma
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2023-12-22 06:05:01 +0100
committerDan Williams <dan.j.williams@intel.com>2024-01-04 22:59:50 +0100
commit5459e186a5c9f412334321cff58d70dcb0e48a04 (patch)
treecac3af985a300d1ee43ffe0bb6f3a0c1fe37685e /drivers/dma
parentcxl/port: Fix decoder initialization when nr_targets > interleave_ways (diff)
downloadlinux-5459e186a5c9f412334321cff58d70dcb0e48a04.tar.xz
linux-5459e186a5c9f412334321cff58d70dcb0e48a04.zip
cxl/port: Fix missing target list lock
cxl_port_setup_targets() modifies the ->targets[] array of a switch decoder. target_list_show() expects to be able to emit a coherent snapshot of that array by "holding" ->target_lock for read. The target_lock is held for write during initialization of the ->targets[] array, but it is not held for write during cxl_port_setup_targets(). The ->target_lock() predates the introduction of @cxl_region_rwsem. That semaphore protects changes to host-physical-address (HPA) decode which is precisely what writes to a switch decoder's target list affects. Replace ->target_lock with @cxl_region_rwsem. Now the side-effect of snapshotting a unstable view of a decoder's target list is likely benign so the Fixes: tag is presumptive. Fixes: 27b3f8d13830 ("cxl/region: Program target lists") Reviewed-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma')
0 files changed, 0 insertions, 0 deletions