diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-21 09:41:16 +0100 |
---|---|---|
committer | Joerg Roedel <jroedel@suse.de> | 2023-03-31 10:01:55 +0200 |
commit | a2972cb89935160bfe515b15d28a77694723ac06 (patch) | |
tree | a50218a6fef6a97298e8f62d8bde9874d8c9992e /drivers/edac/edac_module.h | |
parent | Linux 6.3-rc3 (diff) | |
download | linux-a2972cb89935160bfe515b15d28a77694723ac06.tar.xz linux-a2972cb89935160bfe515b15d28a77694723ac06.zip |
iommu/arm-smmu: Drop if with an always false condition
The remove and shutdown callback are only called after probe completed
successfully. In this case platform_set_drvdata() was called with a
non-NULL argument and so smmu is never NULL. Other functions in this
driver also don't check for smmu being non-NULL before using it.
Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm allocated
resources are freed (among others *smmu and the register mapping). So
after an early exit to iommu device stayed around and using it probably
oopses.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20230321084125.337021-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/edac/edac_module.h')
0 files changed, 0 insertions, 0 deletions