diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-13 12:04:23 +0200 |
|---|---|---|
| committer | Borislav Petkov (AMD) <bp@alien8.de> | 2023-11-20 23:34:04 +0100 |
| commit | 0c7c7ba0c7215de44410e9c4acce28d762dd907a (patch) | |
| tree | 2785dea9f3ff8dc09644e7893343d3b252f2c16d /drivers/edac/layerscape_edac.c | |
| parent | EDAC/zynqmp: Convert to platform remove callback returning void (diff) | |
| download | linux-0c7c7ba0c7215de44410e9c4acce28d762dd907a.tar.xz linux-0c7c7ba0c7215de44410e9c4acce28d762dd907a.zip | |
EDAC/fsl_ddr: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
fsl_mc_err_remove() is used as callback in two drivers. So these have to
be converted together to the void returning remove callback.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20231013100422.1382040-2-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/edac/layerscape_edac.c')
| -rw-r--r-- | drivers/edac/layerscape_edac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/layerscape_edac.c b/drivers/edac/layerscape_edac.c index 7c5e2b3c0daa..d2f895033280 100644 --- a/drivers/edac/layerscape_edac.c +++ b/drivers/edac/layerscape_edac.c @@ -27,7 +27,7 @@ MODULE_DEVICE_TABLE(of, fsl_ddr_mc_err_of_match); static struct platform_driver fsl_ddr_mc_err_driver = { .probe = fsl_mc_err_probe, - .remove = fsl_mc_err_remove, + .remove_new = fsl_mc_err_remove, .driver = { .name = "fsl_ddr_mc_err", .of_match_table = fsl_ddr_mc_err_of_match, |