diff options
author | Douglas Thompson <dougthompson@xmission.com> | 2007-07-19 10:50:17 +0200 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-19 19:04:55 +0200 |
commit | 1c52152b3008b7bdcc3b94d0be4d0b814dce1530 (patch) | |
tree | 652d286f00ac3101dff0f129ad399a1204a38588 /drivers/edac | |
parent | drivers/edac: mod race fix i82875p (diff) | |
download | linux-1c52152b3008b7bdcc3b94d0be4d0b814dce1530.tar.xz linux-1c52152b3008b7bdcc3b94d0be4d0b814dce1530.zip |
drivers/edac: fix ignored return i82875p
Compiling this module gave a warning that the return value of
'pci_bus_add_device()' was not checked.
This patch adds that check and an output message
Signed-off-by: Douglas Thompson <dougthompson@xmission.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/edac')
-rw-r--r-- | drivers/edac/i82875p_edac.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c index 089ec397ca6a..ce5f0053cdd3 100644 --- a/drivers/edac/i82875p_edac.c +++ b/drivers/edac/i82875p_edac.c @@ -270,6 +270,7 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, { struct pci_dev *dev; void __iomem *window; + int err; *ovrfl_pdev = NULL; *ovrfl_window = NULL; @@ -287,7 +288,12 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, if (dev == NULL) return 1; - pci_bus_add_device(dev); + err = pci_bus_add_device(dev); + if (err) { + i82875p_printk(KERN_ERR, + "%s(): pci_bus_add_device() Failed\n", + __func__); + } } *ovrfl_pdev = dev; |