diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-08-26 14:14:37 +0200 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2020-09-01 12:10:19 +0200 |
| commit | 857a3139bd8be4f702c030c8ca06f3fd69c1741a (patch) | |
| tree | 62c805ddb4e8cf592507f8754d626ebd42a44b72 /drivers/edac | |
| parent | EDAC/highbank: Handover Calxeda Highbank maintenance to Andre Przywara (diff) | |
| download | linux-857a3139bd8be4f702c030c8ca06f3fd69c1741a.tar.xz linux-857a3139bd8be4f702c030c8ca06f3fd69c1741a.zip | |
EDAC/i5100: Fix error handling order in i5100_init_one()
When pci_get_device_func() fails, the driver doesn't need to execute
pci_dev_put(). mci should still be freed, though, to prevent a memory
leak. When pci_enable_device() fails, the error injection PCI device
"einj" doesn't need to be disabled either.
[ bp: Massage commit message, rename label to "bail_mc_free". ]
Fixes: 52608ba205461 ("i5100_edac: probe for device 19 function 0")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200826121437.31606-1-dinghao.liu@zju.edu.cn
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/i5100_edac.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c index 191aa7c19ded..324a46b8479b 100644 --- a/drivers/edac/i5100_edac.c +++ b/drivers/edac/i5100_edac.c @@ -1061,16 +1061,15 @@ static int i5100_init_one(struct pci_dev *pdev, const struct pci_device_id *id) PCI_DEVICE_ID_INTEL_5100_19, 0); if (!einj) { ret = -ENODEV; - goto bail_einj; + goto bail_mc_free; } rc = pci_enable_device(einj); if (rc < 0) { ret = rc; - goto bail_disable_einj; + goto bail_einj; } - mci->pdev = &pdev->dev; priv = mci->pvt_info; @@ -1136,14 +1135,14 @@ static int i5100_init_one(struct pci_dev *pdev, const struct pci_device_id *id) bail_scrub: priv->scrub_enable = 0; cancel_delayed_work_sync(&(priv->i5100_scrubbing)); - edac_mc_free(mci); - -bail_disable_einj: pci_disable_device(einj); bail_einj: pci_dev_put(einj); +bail_mc_free: + edac_mc_free(mci); + bail_disable_ch1: pci_disable_device(ch1mm); |