diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2018-06-10 19:45:32 +0200 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2018-06-17 12:23:33 +0200 |
| commit | 9d72fe1ce81bc757ecb6d57b58e5fd95b9ad1b26 (patch) | |
| tree | 86eb833aaf63460b92fbca672ed2cac9df5d8069 /drivers/edac | |
| parent | Linux 4.18-rc1 (diff) | |
| download | linux-9d72fe1ce81bc757ecb6d57b58e5fd95b9ad1b26.tar.xz linux-9d72fe1ce81bc757ecb6d57b58e5fd95b9ad1b26.zip | |
EDAC, altera: Fix an error handling path in altr_s10_sdram_probe()
If regmap_write() fails, we should release some resources as done in all
the other error handling paths of the function.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20180610174532.22071-1-christophe.jaillet@wanadoo.fr
Fixes: e9918d7fafae ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/altera_edac.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index d0d5c4dbe097..5762c3c383f2 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev) S10_DDR0_IRQ_MASK)) { edac_printk(KERN_ERR, EDAC_MC, "Error clearing SDRAM ECC count\n"); - return -ENODEV; + ret = -ENODEV; + goto err2; } if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset, |