diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2009-02-03 17:55:19 +0100 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2009-03-24 20:56:48 +0100 |
| commit | e1eff7a393d4a4e3ad1cf65fcba899146840bfd2 (patch) | |
| tree | 88a040babea1853f40072ed199a78b60f4dcb387 /drivers/firewire/fw-ohci.c | |
| parent | firewire: core: remove condition which is always false (diff) | |
| download | linux-e1eff7a393d4a4e3ad1cf65fcba899146840bfd2.tar.xz linux-e1eff7a393d4a4e3ad1cf65fcba899146840bfd2.zip | |
firewire: normalize a variable name
Standardize on if (err)
handle_error;
and if (ret < 0)
handle_error;
Don't call a variable err if we store values in it which mean success.
Also, offset some return statements by a blank line since this how we do
it in drivers/firewire.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-ohci.c')
| -rw-r--r-- | drivers/firewire/fw-ohci.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c index 859af71b06a8..c92278374658 100644 --- a/drivers/firewire/fw-ohci.c +++ b/drivers/firewire/fw-ohci.c @@ -2459,11 +2459,12 @@ static int __devinit pci_probe(struct pci_dev *dev, reg_read(ohci, OHCI1394_GUIDLo); err = fw_card_add(&ohci->card, max_receive, link_speed, guid); - if (err < 0) + if (err) goto fail_self_id; fw_notify("Added fw-ohci device %s, OHCI version %x.%x\n", dev_name(&dev->dev), version >> 16, version & 0xff); + return 0; fail_self_id: |