summaryrefslogtreecommitdiffstats
path: root/drivers/firewire
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2008-09-12 18:09:55 +0200
committerStefan Richter <stefanr@s5r6.in-berlin.de>2008-10-15 22:21:10 +0200
commit7a1003449c693f0d57443c8786bbf19717921ae0 (patch)
tree41daa9d86f9730c283b72dba22aa2e7703af838c /drivers/firewire
parentfirewire: fw-sbp2: fix another small generation access bug (diff)
downloadlinux-7a1003449c693f0d57443c8786bbf19717921ae0.tar.xz
linux-7a1003449c693f0d57443c8786bbf19717921ae0.zip
firewire: fix setting tag and sy in iso transmission
Reported by Jay Fenlason: The iso packet control accessors in fw-cdev.c had bogus masks. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire')
-rw-r--r--drivers/firewire/fw-cdev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c
index 2e6d5848d217..cfceb2cba4e4 100644
--- a/drivers/firewire/fw-cdev.c
+++ b/drivers/firewire/fw-cdev.c
@@ -720,8 +720,8 @@ static int ioctl_create_iso_context(struct client *client, void *buffer)
#define GET_PAYLOAD_LENGTH(v) ((v) & 0xffff)
#define GET_INTERRUPT(v) (((v) >> 16) & 0x01)
#define GET_SKIP(v) (((v) >> 17) & 0x01)
-#define GET_TAG(v) (((v) >> 18) & 0x02)
-#define GET_SY(v) (((v) >> 20) & 0x04)
+#define GET_TAG(v) (((v) >> 18) & 0x03)
+#define GET_SY(v) (((v) >> 20) & 0x0f)
#define GET_HEADER_LENGTH(v) (((v) >> 24) & 0xff)
static int ioctl_queue_iso(struct client *client, void *buffer)