summaryrefslogtreecommitdiffstats
path: root/drivers/firmware/efi/efi.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@kernel.org>2017-12-12 13:25:54 +0100
committerIngo Molnar <mingo@kernel.org>2017-12-12 13:25:54 +0100
commit76523de61993d015f7895d06deacd3fd454574a1 (patch)
tree7b2890ac9733c55ff73c72bba7b6b5c788ba925b /drivers/firmware/efi/efi.c
parentuprobes/x86: Emulate push insns for uprobe on x86 (diff)
parentLinux 4.15-rc3 (diff)
downloadlinux-76523de61993d015f7895d06deacd3fd454574a1.tar.xz
linux-76523de61993d015f7895d06deacd3fd454574a1.zip
Merge tag 'v4.15-rc3' into perf/core, to refresh the tree
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware/efi/efi.c')
-rw-r--r--drivers/firmware/efi/efi.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index f70febf680c3..557a47829d03 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -109,6 +109,8 @@ struct kobject *efi_kobj;
/*
* Let's not leave out systab information that snuck into
* the efivars driver
+ * Note, do not add more fields in systab sysfs file as it breaks sysfs
+ * one value per file rule!
*/
static ssize_t systab_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
@@ -143,8 +145,7 @@ static ssize_t systab_show(struct kobject *kobj,
return str - buf;
}
-static struct kobj_attribute efi_attr_systab =
- __ATTR(systab, 0400, systab_show, NULL);
+static struct kobj_attribute efi_attr_systab = __ATTR_RO_MODE(systab, 0400);
#define EFI_FIELD(var) efi.var