summaryrefslogtreecommitdiffstats
path: root/drivers/firmware/google/vpd.c
diff options
context:
space:
mode:
authorDave Gerlach <d-gerlach@ti.com>2017-05-18 17:07:06 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-05-18 17:37:52 +0200
commit34cfb106d1f8a746fcccbe61c852f705dcdceaa2 (patch)
tree9fcf296a53d1433d8cfa7b2183d6fe23cb9e73bb /drivers/firmware/google/vpd.c
parentfirmware: google: memconsole: Adapt to new coreboot ring buffer format (diff)
downloadlinux-34cfb106d1f8a746fcccbe61c852f705dcdceaa2.tar.xz
linux-34cfb106d1f8a746fcccbe61c852f705dcdceaa2.zip
misc: sram-exec: Use aligned fncpy instead of memcpy
Currently the sram-exec functionality, which allows allocation of executable memory and provides an API to move code to it, is only selected in configs for the ARM architecture. Based on commit 5756e9dd0de6 ("ARM: 6640/1: Thumb-2: Symbol manipulation macros for function body copying") simply copying a C function pointer address using memcpy without consideration of alignment and Thumb is unsafe on ARM platforms. The aforementioned patch introduces the fncpy macro which is a safe way to copy executable code on ARM platforms, so let's make use of that here rather than the unsafe plain memcpy that was previously used by sram_exec_copy. Now sram_exec_copy will move the code to "dst" and return an address that is guaranteed to be safely callable. In the future, architectures hoping to make use of the sram-exec functionality must define an fncpy macro just as ARM has done to guarantee or check for safe copying to executable memory before allowing the arch to select CONFIG_SRAM_EXEC. Acked-by: Tony Lindgren <tony@atomide.com> Acked-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/firmware/google/vpd.c')
0 files changed, 0 insertions, 0 deletions