diff options
| author | Cristian Marussi <cristian.marussi@arm.com> | 2021-06-08 12:30:56 +0200 |
|---|---|---|
| committer | Sudeep Holla <sudeep.holla@arm.com> | 2021-06-08 16:10:14 +0200 |
| commit | f1748b1ee1fa0fd1a074504045b530b62f949188 (patch) | |
| tree | c6507b1a03155363c846b484110e1844a0ee8ae7 /drivers/firmware | |
| parent | firmware: arm_scmi: Add compatibility checks for shmem node (diff) | |
| download | linux-f1748b1ee1fa0fd1a074504045b530b62f949188.tar.xz linux-f1748b1ee1fa0fd1a074504045b530b62f949188.zip | |
firmware: arm_scmi: Add delayed response status check
A successfully received delayed response could anyway report a failure at
the protocol layer in the message status field.
Add a check also for this error condition.
Link: https://lore.kernel.org/r/20210608103056.3388-1-cristian.marussi@arm.com
Fixes: 58ecdf03dbb9 ("firmware: arm_scmi: Add support for asynchronous commands and delayed response")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/arm_scmi/driver.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index ca71568c5c41..74986bf96656 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -517,8 +517,12 @@ static int do_xfer_with_response(const struct scmi_protocol_handle *ph, xfer->async_done = &async_response; ret = do_xfer(ph, xfer); - if (!ret && !wait_for_completion_timeout(xfer->async_done, timeout)) - ret = -ETIMEDOUT; + if (!ret) { + if (!wait_for_completion_timeout(xfer->async_done, timeout)) + ret = -ETIMEDOUT; + else if (xfer->hdr.status) + ret = scmi_to_linux_errno(xfer->hdr.status); + } xfer->async_done = NULL; return ret; |