diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-22 11:02:51 +0200 |
---|---|---|
committer | Rob Herring <robh@kernel.org> | 2015-10-22 16:26:32 +0200 |
commit | 8363ccb917c6bd497392f5a6b716f46213d86495 (patch) | |
tree | 363113ed45ade4e146d33bf3a46fc8e9cd981016 /drivers/fmc | |
parent | of/unittest: add missing of_node_put (diff) | |
download | linux-8363ccb917c6bd497392f5a6b716f46213d86495.tar.xz linux-8363ccb917c6bd497392f5a6b716f46213d86495.zip |
of/irq: add missing of_node_put
for_each_matching_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
local idexpression n;
expression e;
identifier l;
@@
for_each_matching_node(n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? goto l;
)
...
}
...
l: ... when != n
// </smpl>
Besides the issue found by the semantic patch, this code also stores the
device_node value in a list, which requires an of_node_get, and then cleans
up the list on exit from the function, which requires an of_node_put.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/fmc')
0 files changed, 0 insertions, 0 deletions