diff options
| author | Russ Weight <russell.h.weight@intel.com> | 2022-11-15 01:11:27 +0100 |
|---|---|---|
| committer | Xu Yilun <yilun.xu@intel.com> | 2022-11-15 14:46:58 +0100 |
| commit | dfd10332596ef11ceafd29c4e21b4117be423fc4 (patch) | |
| tree | c5d291f2436b0f3b1abb2bb7913965214a15c594 /drivers/fpga/Kconfig | |
| parent | Linux 6.1-rc1 (diff) | |
| download | linux-dfd10332596ef11ceafd29c4e21b4117be423fc4.tar.xz linux-dfd10332596ef11ceafd29c4e21b4117be423fc4.zip | |
fpga: m10bmc-sec: Fix kconfig dependencies
The secure update driver depends on the firmware-upload functionality of
the firmware-loader. The firmware-loader is carried in the firmware-class
driver which is enabled with the tristate CONFIG_FW_LOADER option. The
firmware-upload functionality is included in the firmware-class driver if
the bool FW_UPLOAD config is set.
The current dependency statement, "depends on FW_UPLOAD", is not adequate
because it does not implicitly turn on FW_LOADER. Instead of adding a
dependency, follow the convention used by drivers that require the
FW_LOADER_USER_HELPER functionality of the firmware-loader by using
select for both FW_LOADER and FW_UPLOAD.
Fixes: bdf86d0e6ca3 ("fpga: m10bmc-sec: create max10 bmc secure update")
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20221115001127.289890-1-russell.h.weight@intel.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Diffstat (limited to 'drivers/fpga/Kconfig')
| -rw-r--r-- | drivers/fpga/Kconfig | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index 6c416955da53..bbe0a7cabb75 100644 --- a/drivers/fpga/Kconfig +++ b/drivers/fpga/Kconfig @@ -246,7 +246,9 @@ config FPGA_MGR_VERSAL_FPGA config FPGA_M10_BMC_SEC_UPDATE tristate "Intel MAX10 BMC Secure Update driver" - depends on MFD_INTEL_M10_BMC && FW_UPLOAD + depends on MFD_INTEL_M10_BMC + select FW_LOADER + select FW_UPLOAD help Secure update support for the Intel MAX10 board management controller. |