diff options
| author | Alan Tull <atull@kernel.org> | 2018-05-17 01:49:54 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-25 18:23:55 +0200 |
| commit | bbaa9cd3a605e337cefc566e5ac1b110763c8d1c (patch) | |
| tree | c38257f4e57adb0d5ec9cd7b706dcc4a0d509292 /drivers/fpga/fpga-region.c | |
| parent | Drivers: hv: vmbus: Removed an unnecessary cast from void * (diff) | |
| download | linux-bbaa9cd3a605e337cefc566e5ac1b110763c8d1c.tar.xz linux-bbaa9cd3a605e337cefc566e5ac1b110763c8d1c.zip | |
fpga: region: don't use drvdata in common fpga code
Changes to fpga_region_register function to not set drvdata.
Setting drvdata is fine for DT based devices that will have one region
per platform device. However PCIe based devices may have multiple
FPGA regions under one PCIe device. Without these changes, the PCIe
solution has to create an extra device for each child region to hold
drvdata.
Signed-off-by: Alan Tull <atull@kernel.org>
Reported-by: Jiuyue Ma <majiuyue@huawei.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/fpga/fpga-region.c')
| -rw-r--r-- | drivers/fpga/fpga-region.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index cb0603e07ff8..f634a8ed5e2c 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -183,7 +183,6 @@ int fpga_region_register(struct device *dev, struct fpga_region *region) region->dev.parent = dev; region->dev.of_node = dev->of_node; region->dev.id = id; - dev_set_drvdata(dev, region); ret = dev_set_name(®ion->dev, "region%d", id); if (ret) |