diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-09-26 16:17:29 +0200 |
|---|---|---|
| committer | Xu Yilun <yilun.xu@intel.com> | 2022-10-25 08:25:02 +0200 |
| commit | 7872d4236f74ad6df4d2c9189b66f95157e24a9b (patch) | |
| tree | 487901e3dce4d5c02c400c4590ea027dcd708e85 /drivers/fpga | |
| parent | Linux 6.1-rc1 (diff) | |
| download | linux-7872d4236f74ad6df4d2c9189b66f95157e24a9b.tar.xz linux-7872d4236f74ad6df4d2c9189b66f95157e24a9b.zip | |
fpga: zynq: Switch to use dev_err_probe() helper
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20220926141729.2292311-1-yangyingliang@huawei.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Diffstat (limited to 'drivers/fpga')
| -rw-r--r-- | drivers/fpga/zynq-fpga.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..ae0da361e6c6 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev) return priv->irq; priv->clk = devm_clk_get(dev, "ref_clk"); - if (IS_ERR(priv->clk)) { - if (PTR_ERR(priv->clk) != -EPROBE_DEFER) - dev_err(dev, "input clock not found\n"); - return PTR_ERR(priv->clk); - } + if (IS_ERR(priv->clk)) + return dev_err_probe(dev, PTR_ERR(priv->clk), + "input clock not found\n"); err = clk_prepare_enable(priv->clk); if (err) { |