diff options
| author | Ed Wildgoose <lists@wildgooses.com> | 2020-09-28 11:44:52 +0200 |
|---|---|---|
| committer | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-09-28 12:22:04 +0200 |
| commit | d25e8fdebdad84219b498873300b7f11dd915b88 (patch) | |
| tree | cd1f386dbced0dbb0e5ecefb0e7eccc53a990fe5 /drivers/gpio/gpio-amd-fch.c | |
| parent | gpio: aspeed: fix ast2600 bank properties (diff) | |
| download | linux-d25e8fdebdad84219b498873300b7f11dd915b88.tar.xz linux-d25e8fdebdad84219b498873300b7f11dd915b88.zip | |
gpio: amd-fch: correct logic of GPIO_LINE_DIRECTION
The original commit appears to have the logic reversed in
amd_fch_gpio_get_direction. Also confirmed by observing the value of
"direction" in the sys tree.
Signed-off-by: Ed Wildgoose <lists@wildgooses.com>
Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers/gpio/gpio-amd-fch.c')
| -rw-r--r-- | drivers/gpio/gpio-amd-fch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-amd-fch.c b/drivers/gpio/gpio-amd-fch.c index 4e44ba4d7423..2a21354ed6a0 100644 --- a/drivers/gpio/gpio-amd-fch.c +++ b/drivers/gpio/gpio-amd-fch.c @@ -92,7 +92,7 @@ static int amd_fch_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio) ret = (readl_relaxed(ptr) & AMD_FCH_GPIO_FLAG_DIRECTION); spin_unlock_irqrestore(&priv->lock, flags); - return ret ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; + return ret ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; } static void amd_fch_gpio_set(struct gpio_chip *gc, |