diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-07-10 04:17:36 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-07-22 15:30:42 +0200 |
| commit | bfab7c8ff89a9dddbe9a08299c24f5e2bf3953f9 (patch) | |
| tree | e53a7f10511269837a0fdfd7dcaf03863b2e3019 /drivers/gpio/gpio-dwapb.c | |
| parent | gpio: merrifield: Protect irq_ack() and gpio_set() by lock (diff) | |
| download | linux-bfab7c8ff89a9dddbe9a08299c24f5e2bf3953f9.tar.xz linux-bfab7c8ff89a9dddbe9a08299c24f5e2bf3953f9.zip | |
gpio: dwapb: add missing fwnode_handle_put() in dwapb_gpio_get_pdata()
fwnode_handle_put() should be used when terminating
device_for_each_child_node() iteration with break or
return to prevent stale device node references from
being left behind.
Generated by Coccinelle.
Fixes: 4ba8cfa79f44 ("gpio: dwapb: convert device node to fwnode")
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-dwapb.c')
| -rw-r--r-- | drivers/gpio/gpio-dwapb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 34779bb375de..6193f62c0df4 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -486,6 +486,7 @@ dwapb_gpio_get_pdata(struct device *dev) pp->idx >= DWAPB_MAX_PORTS) { dev_err(dev, "missing/invalid port index for port%d\n", i); + fwnode_handle_put(fwnode); return ERR_PTR(-EINVAL); } |