diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-11-08 14:40:06 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-11-09 09:43:55 +0100 |
| commit | c82064f26f44ea13f097dfb58d5ffd4359dcabbb (patch) | |
| tree | 731092773f6c54fbb6d4478e4cf670089d9e3b02 /drivers/gpio/gpio-htc-egpio.c | |
| parent | gpio: davinci: Use unique labels for each gpio chip (diff) | |
| download | linux-c82064f26f44ea13f097dfb58d5ffd4359dcabbb.tar.xz linux-c82064f26f44ea13f097dfb58d5ffd4359dcabbb.zip | |
ACPI / gpio: avoid warning for gpio hogging code
The newly added acpi_gpiochip_scan_gpios function produces a few harmless
warnings:
drivers/gpio/gpiolib-acpi.c: In function ‘acpi_gpiochip_add’:
drivers/gpio/gpiolib-acpi.c:925:7: error: ‘dflags’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/gpio/gpiolib-acpi.c:925:9: error: ‘lflags’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
The problem is that he compiler cannot know that a negative return value
from fwnode_property_read_u32_array() or acpi_gpiochip_pin_to_gpio_offset()
implies that the IS_ERR(gpio_desc) is true, as the value could in theory
be below -MAX_ERRNO.
The function already initializes its output values to zero, and moving
that intialization a little higher up ensures that we can never have
uninitialized data in the caller.
Fixes: c80f1ba75df2 ("ACPI / gpio: Add hogging support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions