summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-idt3243x.c
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2022-01-19 02:04:31 +0100
committerBartosz Golaszewski <brgl@bgdev.pl>2022-01-20 09:05:46 +0100
commit7c1cf55577782725ea2bc24687767c8fe8e57486 (patch)
tree09bd38c0d0a165f4a3879625de0f69c075aeba8f /drivers/gpio/gpio-idt3243x.c
parentgpio: idt3243x: Fix IRQ check in idt_gpio_probe (diff)
downloadlinux-7c1cf55577782725ea2bc24687767c8fe8e57486.tar.xz
linux-7c1cf55577782725ea2bc24687767c8fe8e57486.zip
gpio: idt3243x: Fix an ignored error return from platform_get_irq()
The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'parent_irq', so making 'parent_irq' an int. Eliminate the following coccicheck warning: ./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression compared with zero: parent_irq < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Diffstat (limited to '')
-rw-r--r--drivers/gpio/gpio-idt3243x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
index 08493b05be2d..52b8b72ded77 100644
--- a/drivers/gpio/gpio-idt3243x.c
+++ b/drivers/gpio/gpio-idt3243x.c
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct gpio_irq_chip *girq;
struct idt_gpio_ctrl *ctrl;
- unsigned int parent_irq;
+ int parent_irq;
int ngpios;
int ret;