diff options
| author | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2012-10-23 10:17:05 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2012-10-24 07:36:35 +0200 |
| commit | c57d75c099e55500b620f50a207e61b9e20ecd29 (patch) | |
| tree | 97c7726908fda2e1b3f3b6e2bc4d1478a28ad35d /drivers/gpio/gpio-mvebu.c | |
| parent | gpio-74x164: Fix buffer allocation size (diff) | |
| download | linux-c57d75c099e55500b620f50a207e61b9e20ecd29.tar.xz linux-c57d75c099e55500b620f50a207e61b9e20ecd29.zip | |
gpio: mvebu: correctly set the value in direction_output()
The ->direction_output() operation of gpio_chip is supposed to set the
direction to output but also to set the GPIO to an initial
value. Unfortunately, this last part was not done until now, causing
for example the LEDs to not be properly set to their default initial
value. This patch fixes this by calling the mvebu_gpio_set() function
from mvebu_gpio_direction_output() before configuring the GPIO as an
output GPIO.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-mvebu.c')
| -rw-r--r-- | drivers/gpio/gpio-mvebu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 902af437eaf2..1bb43e3f9a61 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -244,6 +244,8 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned pin, if (ret) return ret; + mvebu_gpio_set(chip, pin, value); + spin_lock_irqsave(&mvchip->lock, flags); u = readl_relaxed(mvebu_gpioreg_io_conf(mvchip)); u &= ~(1 << pin); |