summaryrefslogtreecommitdiffstats
path: root/drivers/gpio
diff options
context:
space:
mode:
authorThor Thayer <tthayer@opensource.altera.com>2016-10-25 18:31:23 +0200
committerLinus Walleij <linus.walleij@linaro.org>2016-10-25 20:23:19 +0200
commit5a195c6d4ecf43be26ee1c8be6140025832adfd2 (patch)
tree361a8a073c8d3143c3c291053c045b4b80b4fea4 /drivers/gpio
parentgpio: altera-a10sr: Drop unnecessary gpiochip_remove (diff)
downloadlinux-5a195c6d4ecf43be26ee1c8be6140025832adfd2.tar.xz
linux-5a195c6d4ecf43be26ee1c8be6140025832adfd2.zip
gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing
Confirm the chip->parent is valid before dereferencing because the parent parameter is optional. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
-rw-r--r--drivers/gpio/gpiolib-devprop.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devprop.c
index 17bfc41692ef..27f383bda7d9 100644
--- a/drivers/gpio/gpiolib-devprop.c
+++ b/drivers/gpio/gpiolib-devprop.c
@@ -31,6 +31,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip)
const char **names;
int ret, i;
+ if (!chip->parent) {
+ dev_warn(&gdev->dev, "GPIO chip parent is NULL\n");
+ return;
+ }
+
ret = device_property_read_string_array(chip->parent, "gpio-line-names",
NULL, 0);
if (ret < 0)