diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2018-03-12 12:11:45 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2018-03-19 01:50:30 +0100 |
| commit | 96d0d03dc447993d0eaca5c4294b7560860a378b (patch) | |
| tree | 8f87c0431409cff31add98875615858f2bb834fc /drivers/gpio | |
| parent | gpio: janz-ttl: Include the right header (diff) | |
| download | linux-96d0d03dc447993d0eaca5c4294b7560860a378b.tar.xz linux-96d0d03dc447993d0eaca5c4294b7560860a378b.zip | |
gpio: janz-ttl: Use BIT() macro
This makes the code more readable by using the BIT() macro.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-janz-ttl.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c index e9f4612cd2cc..6b9bf8b7bf16 100644 --- a/drivers/gpio/gpio-janz-ttl.c +++ b/drivers/gpio/gpio-janz-ttl.c @@ -18,6 +18,7 @@ #include <linux/io.h> #include <linux/gpio/driver.h> #include <linux/slab.h> +#include <linux/bitops.h> #include <linux/mfd/janz.h> @@ -33,9 +34,9 @@ #define MASTER_INT_CTL 0x00 #define MASTER_CONF_CTL 0x01 -#define CONF_PAE (1 << 2) -#define CONF_PBE (1 << 7) -#define CONF_PCE (1 << 4) +#define CONF_PAE BIT(2) +#define CONF_PBE BIT(7) +#define CONF_PCE BIT(4) struct ttl_control_regs { __be16 portc; @@ -74,7 +75,7 @@ static int ttl_get_value(struct gpio_chip *gpio, unsigned offset) } spin_lock(&mod->lock); - ret = *shadow & (1 << offset); + ret = *shadow & BIT(offset); spin_unlock(&mod->lock); return !!ret; } @@ -100,9 +101,9 @@ static void ttl_set_value(struct gpio_chip *gpio, unsigned offset, int value) spin_lock(&mod->lock); if (value) - *shadow |= (1 << offset); + *shadow |= BIT(offset); else - *shadow &= ~(1 << offset); + *shadow &= ~BIT(offset); iowrite16be(*shadow, port); spin_unlock(&mod->lock); |