summaryrefslogtreecommitdiffstats
path: root/drivers/gpio
diff options
context:
space:
mode:
authorWilliam Breathitt Gray <vilhelm.gray@gmail.com>2018-04-20 15:50:20 +0200
committerLinus Walleij <linus.walleij@linaro.org>2018-04-30 10:48:08 +0200
commite026646c178d8292de563fbecc247bada059c282 (patch)
treecced27a85129ff2a04f885ab8ac51248751db1d0 /drivers/gpio
parentgpio: pcie-idio-24: Fix port memory offset for get_multiple/set_multiple call... (diff)
downloadlinux-e026646c178d8292de563fbecc247bada059c282.tar.xz
linux-e026646c178d8292de563fbecc247bada059c282.zip
gpio: pcie-idio-24: Fix off-by-one error in get_multiple loop
The PCIe-IDIO-24 features 8 bits of TTL GPIO which may be configured for output or input. This patch fixes an off-by-one error in the loop conditional for the get_multiple callback so that the TTL GPIO are handled. Fixes: ca37081595a2 ("gpio: pcie-idio-24: Implement get_multiple/set_multiple callbacks") Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
-rw-r--r--drivers/gpio/gpio-pcie-idio-24.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
index 3e77c2a9a9fd..f953541e7890 100644
--- a/drivers/gpio/gpio-pcie-idio-24.c
+++ b/drivers/gpio/gpio-pcie-idio-24.c
@@ -217,7 +217,7 @@ static int idio_24_gpio_get_multiple(struct gpio_chip *chip,
bitmap_zero(bits, chip->ngpio);
/* get bits are evaluated a gpio port register at a time */
- for (i = 0; i < ARRAY_SIZE(ports); i++) {
+ for (i = 0; i < ARRAY_SIZE(ports) + 1; i++) {
/* gpio offset in bits array */
bits_offset = i * gpio_reg_size;