summaryrefslogtreecommitdiffstats
path: root/drivers/gpio
diff options
context:
space:
mode:
authorBartosz Golaszewski <brgl@bgdev.pl>2018-07-16 10:34:24 +0200
committerLinus Walleij <linus.walleij@linaro.org>2018-07-16 15:41:26 +0200
commit2b955b34c268af57e3002ece9fd2da70d19b1d5b (patch)
tree06e42ebfe2768129e50a7c1c539e85d51a8df0a5 /drivers/gpio
parentgpiolib: don't allow userspace to set values of input lines (diff)
downloadlinux-2b955b34c268af57e3002ece9fd2da70d19b1d5b.tar.xz
linux-2b955b34c268af57e3002ece9fd2da70d19b1d5b.zip
gpiolib: remove an unnecessary TODO
It's actually fine to read values of output lines. This was also allowed by the legacy sysfs interface. Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
-rw-r--r--drivers/gpio/gpiolib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index c507cd3d01c0..464d5ba79f96 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -431,7 +431,7 @@ static long linehandle_ioctl(struct file *filep, unsigned int cmd,
int i;
if (cmd == GPIOHANDLE_GET_LINE_VALUES_IOCTL) {
- /* TODO: check if descriptors are really input */
+ /* NOTE: It's ok to read values of output lines. */
int ret = gpiod_get_array_value_complex(false,
true,
lh->numdescs,