diff options
| author | Sean Paul <seanpaul@chromium.org> | 2018-08-13 23:30:45 +0200 |
|---|---|---|
| committer | Sean Paul <seanpaul@chromium.org> | 2018-08-14 20:06:13 +0200 |
| commit | 638e9af16b95f6fe0141821d06360039c53ba84d (patch) | |
| tree | 599aaa95cd15cc360b36a294e53375bd043b3e75 /drivers/gpu/drm/bridge | |
| parent | drm/bridge: ti-sn65dsi86: Poll for DP PLL Lock (diff) | |
| download | linux-638e9af16b95f6fe0141821d06360039c53ba84d.tar.xz linux-638e9af16b95f6fe0141821d06360039c53ba84d.zip | |
drm/bridge: ti-sn65dsi86: Poll for training complete
Instead of just waiting 20ms for training to complete, actually poll the
status to ensure training is finished.
Changes in v3:
- Added to the set
Cc: Sandeep Panda <spanda@codeaurora.org>
Reviewed-by: Sandeep Panda <spanda@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20180813213058.184821-7-sean@poorly.run
Diffstat (limited to 'drivers/gpu/drm/bridge')
| -rw-r--r-- | drivers/gpu/drm/bridge/ti-sn65dsi86.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index f02bdedae1e5..d3e27e52ea75 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -493,7 +493,17 @@ static void ti_sn_bridge_enable(struct drm_bridge *bridge) /* Semi auto link training mode */ regmap_write(pdata->regmap, SN_ML_TX_MODE_REG, 0x0A); - msleep(20); /* 20ms delay recommended by spec */ + ret = regmap_read_poll_timeout(pdata->regmap, SN_ML_TX_MODE_REG, val, + val == ML_TX_MAIN_LINK_OFF || + val == ML_TX_NORMAL_MODE, 1000, + 500 * 1000); + if (ret) { + DRM_ERROR("Training complete polling failed (%d)\n", ret); + return; + } else if (val == ML_TX_MAIN_LINK_OFF) { + DRM_ERROR("Link training failed, link is off\n"); + return; + } /* config video parameters */ ti_sn_bridge_set_video_timings(pdata); |