summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/drm_fb_helper.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-08-19 11:46:29 +0200
committerDave Airlie <airlied@redhat.com>2010-08-20 00:48:44 +0200
commit09f0c489fa115a8b88a2da3edd0f3de00c8c7e2e (patch)
treef4134ff56b749de082d89afb1d8878b58a15023b /drivers/gpu/drm/drm_fb_helper.c
parentdrm: fix end of loop test (diff)
downloadlinux-09f0c489fa115a8b88a2da3edd0f3de00c8c7e2e.tar.xz
linux-09f0c489fa115a8b88a2da3edd0f3de00c8c7e2e.zip
drm: move dereference below check
"fb_helper_conn" is dereferenced before the check for NULL. It's never actually NULL here, so this is mostly to keep the static checkers happy. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/drm_fb_helper.c')
-rw-r--r--drivers/gpu/drm/drm_fb_helper.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 719662034bbf..cef8d8da5952 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -94,10 +94,11 @@ static bool drm_fb_helper_connector_parse_command_line(struct drm_fb_helper_conn
int i;
enum drm_connector_force force = DRM_FORCE_UNSPECIFIED;
struct drm_fb_helper_cmdline_mode *cmdline_mode;
- struct drm_connector *connector = fb_helper_conn->connector;
+ struct drm_connector *connector;
if (!fb_helper_conn)
return false;
+ connector = fb_helper_conn->connector;
cmdline_mode = &fb_helper_conn->cmdline_mode;
if (!mode_option)